Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-vm-break-on-sigint to sequential #44140

Merged
merged 1 commit into from
Aug 7, 2022

Commits on Aug 5, 2022

  1. test: move test-vm-break-on-sigint to sequential

    This PR moves `test-vm-break-on-sigint.js` to sequential, following the
    other PRs I have made to move CPU intensive tests into sequential. The
    test has already been tuned to do less iterations in a previous PR.
    However it is still causing ~7% of build failures. The timeouts seem
    highly correlated with other tests which spawn a bunch of threads also
    failing, see for example the [first Jenkins failure][] and the [last
    Jenkins failure][].
    
    [first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
    [last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/
    
    Refs: nodejs#44090
    Refs: nodejs#43981
    Refs: nodejs/reliability#337
    kvakil committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    1eaa78b View commit details
    Browse the repository at this point in the history