Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update lint-md-dependencies to [email protected] #43261

Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of lint-md-dependencies to [email protected].

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 31, 2022
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a patch-only update with no real changes? This feels like a lot of noise for that.

@Trott
Copy link
Member

Trott commented Jun 1, 2022

Not sure why neither the GitHub widget nor the nodejs-github-bot are picking up the fact that there's been more recent Jenkins runs but here are two ones that are going right now.

@Trott
Copy link
Member

Trott commented Jun 1, 2022

This seems like a patch-only update with no real changes? This feels like a lot of noise for that.

You're not wrong, but still, for me, most of the noise is due to CI unreliability (and, uh, perhaps my own penchant for leaving lots of comments....). Otherwise, this would have been landed via fast-track far earlier.

I don't know if it was quite this small, but we had an issue where an update like this broke things on one of the containered builds in Jenkins, so I'm personally OK with small updates like this. Makes it easy to see when something broke instead of having to dig for the needle in the haystack of tons of dependencies being updated at once.

@Trott
Copy link
Member

Trott commented Jun 1, 2022

This one is green. Landing.

@Trott
Copy link
Member

Trott commented Jun 1, 2022

Landed in 29c64ce

Trott pushed a commit that referenced this pull request Jun 1, 2022
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott force-pushed the actions/tools-update-lint-md-dependencies branch from dd7b61a to 5418dd0 Compare June 1, 2022 14:10
@Trott Trott closed this Jun 1, 2022
@Trott Trott force-pushed the actions/tools-update-lint-md-dependencies branch from 5418dd0 to 29c64ce Compare June 1, 2022 14:11
@Trott Trott deleted the actions/tools-update-lint-md-dependencies branch June 1, 2022 14:11
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
PR-URL: nodejs#43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants