Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: export constants from fs/promises #43177

Merged
merged 1 commit into from
Jun 3, 2022
Merged

fs: export constants from fs/promises #43177

merged 1 commit into from
Jun 3, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented May 22, 2022 •
edited
Loading

This pr re-export constants from fs/promises

Motivation

see #43140 (comment)

constants is only export from fs, but not export from fs/promises.

When writing code that uses the promise based fs library via fs/promises, if fs constants is used, we have to add another import module which is not convenient:

import fs from 'fs/promise';
import { constants } from 'fs';

If we re-export constants from fs/promises, then we could reduce two import to one:

import fs, { constants } from 'fs/promises';

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 22, 2022
@F3n67u F3n67u marked this pull request as ready for review May 22, 2022 15:12
@F3n67u F3n67u force-pushed the fs-constants branch 3 times, most recently from 7a98b0b to 1e353ef Compare May 22, 2022 15:36
LiviaMedeiros
LiviaMedeiros reviewed May 25, 2022
View reviewed changes
lib/fs/promises.js Outdated Show resolved Hide resolved
@F3n67u F3n67u requested a review from LiviaMedeiros May 27, 2022 05:25
@F3n67u F3n67u changed the title fs: re-export constants from fs/promises fs: export constants from fs/promises May 27, 2022
@F3n67u
Copy link
Member Author

F3n67u commented May 27, 2022

@LiviaMedeiros I export constants from lib/internal/fs/promises.js instead of adding property at lib/fs/promises.js, please take another look.

@LiviaMedeiros
Copy link
Contributor

Code looks good to me. Shouldn't documentation be updated accordingly?

@F3n67u F3n67u force-pushed the fs-constants branch 2 times, most recently from 7aa855f to 2e1197e Compare May 27, 2022 14:06
@F3n67u
Copy link
Member Author

F3n67u commented May 27, 2022

Code looks good to me. Shouldn't documentation be updated accordingly?

Done. this is the first time to update the Node.js document. please correct me if it is not updated correctly.

lpinca
lpinca approved these changes May 28, 2022
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request May 30, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44239/

This was referenced May 31, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44320/

@github-actions github-actions bot mentioned this pull request Jun 3, 2022
Open
19 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit f765693 into nodejs:master Jun 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f765693

@F3n67u F3n67u deleted the fs-constants branch June 3, 2022 08:56
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
@F3n67u @italojs
fs: export constants from fs/promises
03227dd 
PR-URL: nodejs#43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@F3n67u @danielleadams
fs: export constants from fs/promises
12429d3 
PR-URL: #43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
fs: export constants from fs/promises
9b76453 
PR-URL: #43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
fs: export constants from fs/promises
9d12a5f 
PR-URL: #43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
fs: export constants from fs/promises
8b89c7f 
PR-URL: #43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
fs: export constants from fs/promises
8adaf64 
PR-URL: nodejs/node#43177
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@lvqq lvqq mentioned this pull request Nov 21, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 21, 2022
@lvqq
doc: add version description about fsPromise.constants
07e2ad3 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@lvqq @marco-ippolito
doc: add version description about fsPromise.constants
377f75f 
PR-URL: nodejs#45556
Refs: nodejs#43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
@lvqq @ruyadorno
doc: add version description about fsPromise.constants
4345732 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@lvqq @danielleadams
doc: add version description about fsPromise.constants
9b374c8 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@lvqq @danielleadams
doc: add version description about fsPromise.constants
be18fca 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@lvqq @danielleadams
doc: add version description about fsPromise.constants
8e94339 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@lvqq @danielleadams
doc: add version description about fsPromise.constants
97831c0 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@lvqq @danielleadams
doc: add version description about fsPromise.constants
d09447c 
PR-URL: #45556
Refs: #43177
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@F3n67u @LiviaMedeiros @nodejs-github-bot @lpinca @aduh95