Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unnecessary comment in node_process_events.cc #42952

Merged
merged 1 commit into from
May 6, 2022
Merged

src: remove unnecessary comment in node_process_events.cc #42952

merged 1 commit into from
May 6, 2022

Conversation

cola119
Copy link
Member

@cola119 cola119 commented May 3, 2022 •
edited
Loading

I found meaningless comment in node_process_events.cc. I think this is unintentionally duplicated by #25397 (cc @joyeecheung)
The correct location of this comment is here:

node/src/inspector_agent.cc

Lines 341 to 351 in 2be5966

void NotifyClusterWorkersDebugEnabled(Environment* env) {
Isolate* isolate = env->isolate();
HandleScope handle_scope(isolate);
Local<Context> context = env->context();
// Send message to enable debug in cluster workers
Local<Object> message = Object::New(isolate);
message->Set(context, FIXED_ONE_BYTE_STRING(isolate, "cmd"),
FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")).Check();
ProcessEmit(env, "internalMessage", message);
}

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 3, 2022
joyeecheung
joyeecheung approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this comment was added but yeah the analysis sounds about right 👍

@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43906/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3bc23f5 into nodejs:master May 6, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3bc23f5

@cola119 cola119 deleted the chore-remove-unnecessary-comment branch May 7, 2022 03:42
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@cola119 @RafaelGSS
src: remove unnecessary comment
5dc7929 
PR-URL: #42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@cola119 @juanarbol
src: remove unnecessary comment
eecf820 
PR-URL: #42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@cola119 @danielleadams
src: remove unnecessary comment
31d77ad 
PR-URL: #42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@cola119 @targos
src: remove unnecessary comment
3b09330 
PR-URL: #42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@cola119 @targos
src: remove unnecessary comment
4cfcb6f 
PR-URL: #42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@cola119 @guangwong
src: remove unnecessary comment
ceef45c 
PR-URL: nodejs/node#42952
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cola119 @nodejs-github-bot @tniessen @joyeecheung @aduh95