From 3a1c6aeeb4f5062a5ca3f50f64add68e4877f5a4 Mon Sep 17 00:00:00 2001
From: Erick Wendel <erick.workspace@gmail.com>
Date: Thu, 14 Apr 2022 10:53:37 -0300
Subject: [PATCH 1/5] doc,test: add tests and docs for duplex.fromWeb and
 duplex.toWeb

---
 doc/api/stream.md                   | 54 +++++++++++++++++++
 test/parallel/test-stream-duplex.js | 80 ++++++++++++++++++++++++++++-
 2 files changed, 133 insertions(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index d59cd6b51629e4..25ed69ce97e94f 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -2874,6 +2874,38 @@ added: v17.0.0
   * `signal` {AbortSignal}
 * Returns: {stream.Duplex}
 
+```mjs
+import { Duplex } from 'stream';
+import {
+  ReadableStream,
+  WritableStream
+} from 'stream/web';
+
+const readable = new ReadableStream({
+  start(controller) {
+    controller.enqueue('world');
+  },
+});
+
+const writable = new WritableStream({
+  write(chunk) {
+    console.log('writable', chunk);
+  }
+});
+
+const pair = {
+  readable,
+  writable
+};
+const duplex = Duplex.fromWeb(pair, { encoding: 'utf8', objectMode: true });
+
+duplex.write('hello');
+
+for await (const chunk of duplex) {
+  console.log('readable', chunk);
+}
+```
+
 ### `stream.Duplex.toWeb(streamDuplex)`
 
 <!-- YAML
@@ -2887,6 +2919,28 @@ added: v17.0.0
   * `readable` {ReadableStream}
   * `writable` {WritableStream}
 
+```mjs
+import { Duplex } from 'stream';
+
+const duplex = Duplex({
+  objectMode: true,
+  read() {
+    this.push('world');
+    this.push(null);
+  },
+  write: (chunk, encoding, callback) => {
+    console.log('writable', chunk);
+    callback();
+  }
+});
+
+const { readable, writable } = Duplex.toWeb(duplex);
+writable.getWriter().write('hello');
+
+const { value } = await readable.getReader().read();
+console.log('readable', value);
+```
+
 ### `stream.addAbortSignal(signal, stream)`
 
 <!-- YAML
diff --git a/test/parallel/test-stream-duplex.js b/test/parallel/test-stream-duplex.js
index 2b2f9a9a0e6265..e2438f3fe5c149 100644
--- a/test/parallel/test-stream-duplex.js
+++ b/test/parallel/test-stream-duplex.js
@@ -20,9 +20,10 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 'use strict';
 
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const Duplex = require('stream').Duplex;
+const { ReadableStream, WritableStream } = require('stream/web');
 
 const stream = new Duplex({ objectMode: true });
 
@@ -53,3 +54,80 @@ process.on('exit', () => {
   assert.strictEqual(read.val, 1);
   assert.strictEqual(written.val, 2);
 });
+
+// Duplex.fromWeb
+{
+  const dataToRead = Buffer.from('hello');
+  const dataToWrite = Buffer.from('world');
+
+  const stream = new ReadableStream({
+    start(controller) {
+      controller.enqueue(dataToRead);
+    },
+  });
+
+  const writable = new WritableStream({
+    write: common.mustCall((chunk) => {
+      assert.strictEqual(chunk, dataToWrite);
+    })
+  });
+
+  const pair = { readable: stream, writable: writable };
+  const duplex = Duplex.fromWeb(pair);
+
+  duplex.write(dataToWrite);
+  duplex.once('data', common.mustCall((chunk) => {
+    assert.strictEqual(chunk, dataToRead);
+  }));
+}
+
+// Duplex.fromWeb - using utf8 and objectMode
+{
+  const dataToRead = 'hello';
+  const dataToWrite = 'world';
+
+  const stream = new ReadableStream({
+    start(controller) {
+      controller.enqueue(dataToRead);
+    },
+  });
+
+  const writable = new WritableStream({
+    write: common.mustCall((chunk) => {
+      assert.strictEqual(chunk, dataToWrite);
+    })
+  });
+
+  const pair = {
+    readable: stream,
+    writable: writable
+  };
+  const duplex = Duplex.fromWeb(pair, { encoding: 'utf8', objectMode: true });
+
+  duplex.write(dataToWrite);
+  duplex.once('data', common.mustCall((chunk) => {
+    assert.strictEqual(chunk, dataToRead);
+  }));
+}
+// Duplex.toWeb
+{
+  const dataToRead = Buffer.from('hello');
+  const dataToWrite = Buffer.from('world');
+
+  const duplex = Duplex({
+    read() {
+      this.push(dataToRead);
+      this.push(null);
+    },
+    write: common.mustCall((chunk) => {
+      assert.strictEqual(chunk, dataToWrite);
+    })
+  });
+
+  const webDuplex = Duplex.toWeb(duplex);
+  webDuplex.writable.getWriter().write(dataToWrite);
+
+  webDuplex.readable.getReader().read().then(common.mustCall((result) => {
+    assert.deepStrictEqual(Buffer.from(result.value), dataToRead);
+  }));
+}

From d24855469fb35673393c8bf8240044ef5ef2518c Mon Sep 17 00:00:00 2001
From: Erick Wendel <erick.workspace@gmail.com>
Date: Fri, 15 Apr 2022 10:59:03 -0300
Subject: [PATCH 2/5] all small nits suggestions

Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
---
 doc/api/stream.md                   |  2 +-
 test/parallel/test-stream-duplex.js | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 25ed69ce97e94f..1a55ca7774001e 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -2928,7 +2928,7 @@ const duplex = Duplex({
     this.push('world');
     this.push(null);
   },
-  write: (chunk, encoding, callback) => {
+  write(chunk, encoding, callback) {
     console.log('writable', chunk);
     callback();
   }
diff --git a/test/parallel/test-stream-duplex.js b/test/parallel/test-stream-duplex.js
index e2438f3fe5c149..490744910cb1e1 100644
--- a/test/parallel/test-stream-duplex.js
+++ b/test/parallel/test-stream-duplex.js
@@ -60,7 +60,7 @@ process.on('exit', () => {
   const dataToRead = Buffer.from('hello');
   const dataToWrite = Buffer.from('world');
 
-  const stream = new ReadableStream({
+  const readable = new ReadableStream({
     start(controller) {
       controller.enqueue(dataToRead);
     },
@@ -72,7 +72,7 @@ process.on('exit', () => {
     })
   });
 
-  const pair = { readable: stream, writable: writable };
+  const pair = { readable, writable };
   const duplex = Duplex.fromWeb(pair);
 
   duplex.write(dataToWrite);
@@ -86,7 +86,7 @@ process.on('exit', () => {
   const dataToRead = 'hello';
   const dataToWrite = 'world';
 
-  const stream = new ReadableStream({
+  const readable = new ReadableStream({
     start(controller) {
       controller.enqueue(dataToRead);
     },
@@ -99,8 +99,8 @@ process.on('exit', () => {
   });
 
   const pair = {
-    readable: stream,
-    writable: writable
+    readable,
+    writable
   };
   const duplex = Duplex.fromWeb(pair, { encoding: 'utf8', objectMode: true });
 
@@ -124,10 +124,10 @@ process.on('exit', () => {
     })
   });
 
-  const webDuplex = Duplex.toWeb(duplex);
-  webDuplex.writable.getWriter().write(dataToWrite);
+  const { writable, readable } = Duplex.toWeb(duplex);
+  writable.getWriter().write(dataToWrite);
 
-  webDuplex.readable.getReader().read().then(common.mustCall((result) => {
+  readable.getReader().read().then(common.mustCall((result) => {
     assert.deepStrictEqual(Buffer.from(result.value), dataToRead);
   }));
 }

From c7f95ff40f266243e78e153575c029f9ff9356a8 Mon Sep 17 00:00:00 2001
From: Erick Wendel <erick.workspace@gmail.com>
Date: Mon, 18 Apr 2022 09:52:15 -0300
Subject: [PATCH 3/5] add example in cjs to enable toggle docs

Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
---
 doc/api/stream.md | 52 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 1a55ca7774001e..1a0c0a042585f1 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -2906,6 +2906,35 @@ for await (const chunk of duplex) {
 }
 ```
 
+```cjs
+const { Duplex } = require('stream');
+const {
+  ReadableStream,
+  WritableStream
+} = require('stream/web');
+
+const readable = new ReadableStream({
+  start(controller) {
+    controller.enqueue('world');
+  },
+});
+
+const writable = new WritableStream({
+  write(chunk) {
+    console.log('writable', chunk);
+  }
+});
+
+const pair = {
+  readable,
+  writable
+};
+const duplex = Duplex.fromWeb(pair, { encoding: 'utf8', objectMode: true });
+
+duplex.write('hello');
+duplex.once('readable', () => console.log('readable', duplex.read()));
+```
+
 ### `stream.Duplex.toWeb(streamDuplex)`
 
 <!-- YAML
@@ -2941,6 +2970,29 @@ const { value } = await readable.getReader().read();
 console.log('readable', value);
 ```
 
+```cjs
+const { Duplex } = require('stream');
+
+const duplex = Duplex({
+  objectMode: true,
+  read() {
+    this.push('world');
+    this.push(null);
+  },
+  write(chunk, encoding, callback) {
+    console.log('writable', chunk);
+    callback();
+  }
+});
+
+const { readable, writable } = Duplex.toWeb(duplex);
+writable.getWriter().write('hello');
+
+readable.getReader().read().then((result) => {
+  console.log('readable', result.value);
+});
+```
+
 ### `stream.addAbortSignal(signal, stream)`
 
 <!-- YAML

From d5d117ec9f7409ce68b4fde12cd68eec971cc186 Mon Sep 17 00:00:00 2001
From: Erick Wendel <erick.workspace@gmail.com>
Date: Tue, 19 Apr 2022 21:10:51 -0300
Subject: [PATCH 4/5] Update doc/api/stream.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/stream.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 1a0c0a042585f1..068dbfa0742dcf 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -2875,7 +2875,7 @@ added: v17.0.0
 * Returns: {stream.Duplex}
 
 ```mjs
-import { Duplex } from 'stream';
+import { Duplex } from 'node:stream';
 import {
   ReadableStream,
   WritableStream

From 6e2967e736ba169c6308c5729973128613c8c7ff Mon Sep 17 00:00:00 2001
From: Erick Wendel <erick.workspace@gmail.com>
Date: Tue, 19 Apr 2022 21:11:43 -0300
Subject: [PATCH 5/5] docs: apply suggestions from code review

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/stream.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/api/stream.md b/doc/api/stream.md
index 068dbfa0742dcf..0526e696f54c13 100644
--- a/doc/api/stream.md
+++ b/doc/api/stream.md
@@ -2879,7 +2879,7 @@ import { Duplex } from 'node:stream';
 import {
   ReadableStream,
   WritableStream
-} from 'stream/web';
+} from 'node:stream/web';
 
 const readable = new ReadableStream({
   start(controller) {
@@ -2907,11 +2907,11 @@ for await (const chunk of duplex) {
 ```
 
 ```cjs
-const { Duplex } = require('stream');
+const { Duplex } = require('node:stream');
 const {
   ReadableStream,
   WritableStream
-} = require('stream/web');
+} = require('node:stream/web');
 
 const readable = new ReadableStream({
   start(controller) {
@@ -2949,7 +2949,7 @@ added: v17.0.0
   * `writable` {WritableStream}
 
 ```mjs
-import { Duplex } from 'stream';
+import { Duplex } from 'node:stream';
 
 const duplex = Duplex({
   objectMode: true,
@@ -2971,7 +2971,7 @@ console.log('readable', value);
 ```
 
 ```cjs
-const { Duplex } = require('stream');
+const { Duplex } = require('node:stream');
 
 const duplex = Duplex({
   objectMode: true,