-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix outgoingMessage.removeHeader() signature #42652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
labels
Apr 8, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string.
lpinca
force-pushed
the
add/missing-argument
branch
from
April 8, 2022 07:04
3e89179
to
d93a1df
Compare
lpinca
changed the title
doc: add missing argument to function signature
doc: fix outgoingMessage.removeHeader() signature
Apr 8, 2022
ShogunPanda
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ronag
approved these changes
Apr 8, 2022
mcollina
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
VoltrexKeyva
approved these changes
Apr 8, 2022
cjihrig
approved these changes
Apr 8, 2022
marsonya
approved these changes
Apr 9, 2022
marsonya
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 9, 2022
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 10, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 10, 2022
Landed in 13ad8d4 |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: nodejs#42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: nodejs/node#42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that
outgoingMessage.removeHeader()
takes aname
argumentwhose type is string.