doc: change AES-GCM IV recommendation in WebCrypto #42611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
panva
approved these changes
Apr 5, 2022
tniessen
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6706be1 |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42611 Reviewed-By: Filip Skokan <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42611 Reviewed-By: Filip Skokan <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42611 Reviewed-By: Filip Skokan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42611 Reviewed-By: Filip Skokan <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42611 Reviewed-By: Filip Skokan <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42611 Reviewed-By: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly constructing IVs is one of the most important factors when using AES-GCM. Contrary to what the documentation says, random values are not ideal, however, sufficiently long random byte sequences are acceptable when the application cannot deterministically construct unique IVs.
Instead of referring to "the AES-GCM specification", explicitly refer to Section 8 of NIST SP 800-38D.