doc: improve SSL_OP_PRIORITIZE_CHACHA description #41866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does."
nodejs-github-bot
added
crypto
Trott
approved these changes
Feb 5, 2022
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Mesteery
approved these changes
Feb 5, 2022
Mesteery
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 37cb165 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: #41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: #41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: #41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: nodejs#41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: nodejs#41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 8, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: #41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
The cipher should be spelled "ChaCha20-Poly1305", i.e., with a hyphen between the encryption and MAC algorithm names. Also change "when client does" to "when the client does." PR-URL: #41866 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cipher should be spelled
ChaCha20-Poly1305, i.e., with a hyphen between the encryption and MAC algorithm names. Also changewhen client doestowhen the client does.