-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: add jsdoc details for Event and EventTarget #41274
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <[email protected]>
aduh95
approved these changes
Dec 21, 2021
Trott
reviewed
Dec 21, 2021
Co-authored-by: Rich Trott <[email protected]>
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Dec 21, 2021
benjamingr
approved these changes
Dec 22, 2021
edsadr
approved these changes
Dec 22, 2021
jasnell
added a commit
that referenced
this pull request
Dec 24, 2021
Signed-off-by: James M Snell <[email protected]> PR-URL: #41274 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Landed in 9d6bd10 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Signed-off-by: James M Snell <[email protected]> PR-URL: #41274 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Signed-off-by: James M Snell <[email protected]> PR-URL: #41274 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#41274 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Signed-off-by: James M Snell <[email protected]> PR-URL: #41274 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
typings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell [email protected]