test: mark test-crypto-keygen flaky on windows #41207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
needs-ci
|
Identified as one of the top intermittent failures in recent reliability reports as part of our Red Hat team day to see what we could do to help move CI closer to green. |
richardlau
reviewed
Dec 16, 2021
test/parallel/parallel.status
Outdated
| @@ -11,6 +11,8 @@ prefix parallel | |||
| test-timers-immediate-queue: PASS,FLAKY | |||
| # https://github.com/nodejs/node/issues/23277 | |||
| test-worker-memory: PASS,FLAKY | |||
| # https://github.com/nodejs/node/issues/41206 | |||
| test-crypto-keygen: SLOW | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@richardlau thanks for pointing that out. Updated to mark as flaky instead.
mhdawson
changed the title
richardlau
approved these changes
Dec 16, 2021
jasnell
approved these changes
Dec 17, 2021
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41207 ✔ Done loading data for nodejs/node/pull/41207 ----------------------------------- PR info ------------------------------------ Title test: mark test-crypto-keygen flaky on windows (#41207) Author Michael Dawson (@mhdawson) Branch mhdawson:slow-windows -> nodejs:master Labels test, needs-ci Commits 2 - test: mark test-crypto-keygen slow on windows - Update parallel.status Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/41207 Refs: https://github.com/nodejs/node/issues/41206 Reviewed-By: Richard Lau Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41207 Refs: https://github.com/nodejs/node/issues/41206 Reviewed-By: Richard Lau Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Dec 2021 20:20:55 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41207#pullrequestreview-834630872 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41207#pullrequestreview-835346669 ✖ Last GitHub CI failed ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1598856323 |
22 tasks
mhdawson
added a commit
that referenced
this pull request
Dec 21, 2021
Refs: #41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41207 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in eee1a6f |
This was referenced Dec 22, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: #41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41207 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Refs: #41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41207 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs#41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41207 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: #41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41207 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #41206
This test seems to be failing regularly on
windows with a timeout. Mark it slow to reduce
CI noise until it gets investigated.
Signed-off-by: Michael Dawson [email protected]