Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move one or more collaborators to emeritus #41154

Merged
merged 1 commit into from
Dec 15, 2021
Merged

meta: move one or more collaborators to emeritus #41154

merged 1 commit into from
Dec 15, 2021

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Dec 13, 2021
DerekNonGeneric
DerekNonGeneric approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been nice to collaborate on loaders design, especially since we still want to ensure that our still experimental API can meet the APM use case(s).

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Dec 13, 2021
@Trott
Copy link
Member

Trott commented Dec 13, 2021

Adding blocked because our governance docs/rules are such that a collaborator can only be moved to emeritus if they agree to it or if the TSC votes to do it.

@watson @nodejs/tsc

@DerekNonGeneric
Copy link
Contributor

@watson, do you think you'd be interested in getting re-involved?

The @nodejs/loaders team could use more input from APM vendors/those versed in the subject. I'm not sure if anyone has yet, but I meant to reach out a while back to see how we could ensure that this use case, in particular, is well-supported. We're still a couple of iterations away from stabilizing custom module loading (our hooks system), so it's not too late for feedback/collaboration if you're willing to help out. It would be good to have your thoughts on our progress and also good to know what Elastic would need as far as hooks are concerned if they intend to support newer Node.js applications (those not using CommonJS as their module format).

Please let us know; team membership is open to anyone interested in getting involved/contributing to this testing/feedback/re-engineering research & development loop we're in currently. I am also happy to dismiss my review as stale for any other reason, but if joining a new team is something you see yourself doing, Loaders might be one worth considering. 😉

@Trott
Copy link
Member

Trott commented Dec 13, 2021

I am also happy to dismiss my review

Same.

mcollina
mcollina approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobJingleheimer
Copy link
Member

@DerekNonGeneric I did already reach out to APMs. It was discussed at at least a couple Loaders team meetings.

@Mesteery Mesteery mentioned this pull request Dec 13, 2021
Closed
Mesteery added a commit to Mesteery/node that referenced this pull request Dec 13, 2021
@Mesteery
build: update find-inactive-collaborators labels
7e5ff77 
Automatically add `blocked` label for find-inactive-collaborators's PRs.

Refs: nodejs#41154 (comment)
@Trott Trott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Dec 15, 2021
mhdawson
mhdawson approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Dec 15, 2021

Now that #41155 has landed, this is no longer blocked.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Dec 15, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2021
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/41154
✔  Done loading data for nodejs/node/pull/41154
----------------------------------- PR info ------------------------------------
Title      meta: move one or more collaborators to emeritus (#41154)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/inactive-collaborators -> nodejs:master
Labels     doc, meta
Commits    1
 - meta: move one or more collaborators to emeritus
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/41154
Reviewed-By: Derek Lewis 
Reviewed-By: Rich Trott 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41154
Reviewed-By: Derek Lewis 
Reviewed-By: Rich Trott 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 13 Dec 2021 04:09:33 GMT
   ✔  Approvals: 10
   ✔  - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/41154#pullrequestreview-829762431
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829778163
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829838497
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829909980
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830234258
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830564675
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-832762876
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41154#pullrequestreview-833365737
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833427239
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833446593
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1584867256

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 15, 2021
@nodejs-github-bot @Trott
meta: move one or more collaborators to emeritus
162e5a1 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 15, 2021

Landed in 162e5a1

@Trott Trott force-pushed the actions/inactive-collaborators branch from e5260eb to 162e5a1 Compare December 15, 2021 22:11
@Trott Trott merged commit 162e5a1 into master Dec 15, 2021
@DerekNonGeneric DerekNonGeneric deleted the actions/inactive-collaborators branch December 15, 2021 22:12
@Trott
Copy link
Member

Trott commented Dec 15, 2021 •
edited
Loading

I've blocked @ssua91 so we can all have a reduction in notification spam.

Refs (in addition to the two reviews in this PR)

@DerekNonGeneric DerekNonGeneric removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 16, 2021
danielleadams pushed a commit that referenced this pull request Dec 16, 2021
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
0e4662d 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
03e6771 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott mentioned this pull request Dec 20, 2021
Closed
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
a9f15fb 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
109061f 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@nodejs-github-bot @Linkgoron
meta: move one or more collaborators to emeritus
2890942 
PR-URL: nodejs#41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@nodejs-github-bot @danielleadams
meta: move one or more collaborators to emeritus
5ac6027 
PR-URL: #41154
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssua91 ssua91 ssua91 approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.