Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add IIFE test for REPL #41047

Closed
wants to merge 3 commits into from
Closed

test: add IIFE test for REPL #41047

wants to merge 3 commits into from

Conversation

binvb
Copy link

@binvb binvb commented Dec 1, 2021

add IIFE test for REPL;
Refs: #38685

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 1, 2021
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this.
Did you consider adding test cases to test/parallel/test-repl.js instead of creating a new file? We could probably avoid the first lines of boilerplate.

test/parallel/test-repl-IIFE.js Outdated Show resolved Hide resolved

stream.run([asyncFn]);
// promise output twice
output = util.inspect(output).split('\\n> ')[1];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using util.inspect here?

@aduh95
Copy link
Contributor

aduh95 commented Dec 10, 2021

Can you rebase to fix the number of commits in the PR? You can use the following commands to do so:

git fetch https://github.com/nodejs/node.git master
git reset FETCH_HEAD --hard
git cherry-pick c5acdd3a07acf62086b71f0e31e45c613c774ecd
git cherry-pick d7579bbfc93b70dc0221067590f5464ff977cd63
git push origin HEAD:master --hard

If you have issues with the rebase, let me know, I might be able to do it for you.

@binvb binvb force-pushed the master branch 3 times, most recently from 75d470c to 8ebcb55 Compare December 13, 2021 01:58
@binvb
Copy link
Author

binvb commented Dec 13, 2021

Can you rebase to fix the number of commits in the PR? You can use the following commands to do so:

git fetch https://github.com/nodejs/node.git master
git reset FETCH_HEAD --hard
git cherry-pick c5acdd3a07acf62086b71f0e31e45c613c774ecd
git cherry-pick d7579bbfc93b70dc0221067590f5464ff977cd63
git push origin HEAD:master --hard

If you have issues with the rebase, let me know, I might be able to do it for you.

thank you for detail, i still working in this. there has an error when i use: git push origin HEAD:master --hard:

error: unknown option `hard'

can i use --force?

git push origin HEAD:master --force-with-lease

@aduh95
Copy link
Contributor

aduh95 commented Dec 13, 2021

Oh yes, I meant force, not hard.

@RaisinTen
Copy link
Contributor

Hi @binvb, are you still interested in working on this? FYI, #44878 was opened recently and that also attempts to add a similar test.

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label Sep 20, 2023
@github-actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants