typings: add types for symbol and accessor properties on primordials
#40992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
force-pushed
the
typings/primordials/add-symbol-and-accessor-properties
branch
from
686be5a
to
f4c00aa
Compare
ExE-Boss
changed the title
primordials
ExE-Boss
force-pushed
the
typings/primordials/add-symbol-and-accessor-properties
branch
from
f4c00aa
to
b2b15f1
Compare
ExE-Boss
changed the title
primordialsprimordials
Does this matter in a |
jasnell
approved these changes
Nov 29, 2021
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40992 ✔ Done loading data for nodejs/node/pull/40992 ----------------------------------- PR info ------------------------------------ Title typings: add types for symbol and accessor properties on `primordials` (#40992) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ExE-Boss:typings/primordials/add-symbol-and-accessor-properties -> nodejs:master Labels typings Commits 1 - typings: add types for symbol and accessor properties on `primordials` Committers 1 - ExE Boss PR-URL: https://github.com/nodejs/node/pull/40992 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40992 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 27 Nov 2021 14:01:05 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40992#pullrequestreview-817916369 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1639087835 |
nodejs-github-bot
added
the
commit-queue-failed
|
Landed in c93ba41 |
ExE-Boss
deleted the
typings/primordials/add-symbol-and-accessor-properties
branch
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #40992 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #40992 Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#40992 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40992 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed the types of
primordials.uncurryThisandprimordials.AsyncIteratorPrototype, added%TypedArray%statics, and made global properties use:In order to re‑export types as well as values.