Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 8.3.0 #40917

Merged
merged 1 commit into from
Nov 22, 2021
Merged

tools: update ESLint to 8.3.0 #40917

merged 1 commit into from
Nov 22, 2021

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 21, 2021

Update ESLint to 8.3.0

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 21, 2021
cjihrig
cjihrig approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp 👍

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2021
@nodejs-github-bot nodejs-github-bot merged commit 7ad052d into nodejs:master Nov 22, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ad052d

@lpinca lpinca deleted the update/eslint branch November 22, 2021 14:09
targos pushed a commit that referenced this pull request Nov 26, 2021
@lpinca @targos
tools: update ESLint to 8.3.0
e674f61 
PR-URL: #40917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@lpinca @danielleadams
tools: update ESLint to 8.3.0
1d78a8a 
PR-URL: #40917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@lpinca @danielleadams
tools: update ESLint to 8.3.0
96cfab1 
PR-URL: #40917
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @nodejs-github-bot @Trott @targos @cjihrig @VoltrexKeyva