doc: Grammar/typo fix for https.Agent section #4075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
https
| @@ -195,7 +195,7 @@ Example: | |||
| ... | |||
| } | |||
|
|
|||
| Or does not use an `Agent`. | |||
| Or don't use an `Agent`. | |||
There was a problem hiding this comment.
Could you make this:
Alternatively, without an
Agent.
There was a problem hiding this comment.
I tried to keep it to the grammar fix only. When changing the wording, I'd rather use something along these lines:
Alternatively, opt out of connection pooling.
That's how agent: false is documented above and describes the intent/effect instead of an implementation detail.
There was a problem hiding this comment.
How about this, to make it more clear what is different:
Alternatively, opt out of connection pooling by not using an
Agent.
jkrems
force-pushed
the
https-doc-typo
branch
from
0f0b4ca
to
0d49516
Compare
cjihrig
pushed a commit
that referenced
this pull request
Dec 2, 2015
PR-URL: #4075 Reviewed-By: Colin Ihrig <[email protected]>
|
Thanks! LGTM and landed in 8eb153d. |
rvagg
pushed a commit
that referenced
this pull request
Dec 5, 2015
PR-URL: #4075 Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 8, 2015
MylesBorins
pushed a commit
that referenced
this pull request
Dec 15, 2015
PR-URL: #4075 Reviewed-By: Colin Ihrig <[email protected]>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
PR-URL: #4075 Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
PR-URL: #4075 Reviewed-By: Colin Ihrig <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4075 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use imperative to be consistent with "use a custom
Agent" above.