Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: return readable stream on promisified pipeline #40653

Closed
wants to merge 1 commit into from
Closed

stream: return readable stream on promisified pipeline #40653

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 29, 2021 •
edited
Loading

Otherwise it's impossible to read the remaining data...

@ronag ronag requested review from mcollina and lpinca October 29, 2021 10:50
@ronag ronag added semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem. labels Oct 29, 2021
@ronag
Copy link
Member Author

ronag commented Oct 29, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021
@ronag ronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
@ronag
Copy link
Member Author

ronag commented Oct 29, 2021

@mcollina semver minor or major? wdyt?

@ronag ronag mentioned this pull request Oct 29, 2021
Closed
@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
@ronag ronag mentioned this pull request Nov 1, 2021
Open
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40715/

mcollina
mcollina requested changes Nov 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the docs?

This was referenced Nov 5, 2021
Open
Open
Open
@ronag ronag closed this Nov 7, 2021
@ronag
Copy link
Member Author

ronag commented Nov 7, 2021

Probably better to just use stream.compose in this scenario.

@github-actions github-actions bot mentioned this pull request Nov 8, 2021
Open
46 tasks
@joyeecheung joyeecheung mentioned this pull request Nov 8, 2021
Closed
This was referenced Nov 9, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@lpinca lpinca lpinca left review comments

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @mcollina @lpinca @Mesteery