doc: tweak guidance for modules in core #40601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the diff is not great due to the file rename. It's mostly
|
Trott
reviewed
Oct 25, 2021
Trott
reviewed
Oct 25, 2021
Trott
reviewed
Oct 25, 2021
|
@Trott addressed your comments if you can take another look. |
Trott
reviewed
Oct 27, 2021
Trott
reviewed
Oct 28, 2021
ronag
approved these changes
Nov 2, 2021
ronag
reviewed
Nov 2, 2021
|
@Trott one more look? |
Trott
reviewed
Nov 9, 2021
Trott
reviewed
Nov 9, 2021
tniessen
approved these changes
Nov 11, 2021
|
@Trott updated again. |
Trott
added
the
author ready
Trott
approved these changes
Nov 13, 2021
|
Probably worth a ping to @nodejs/tsc on this. |
jasnell
approved these changes
Nov 13, 2021
ronag
approved these changes
Nov 13, 2021
Generalize guidance so that it is not specific to modules. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#40601 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in b323c63 |
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
Generalize guidance so that it is not specific to modules. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40601 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Generalize guidance so that it is not specific to modules. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40601 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Generalize guidance so that it is not specific to modules. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40601 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize guidance so that it is not specific
to modules.
Signed-off-by: Michael Dawson [email protected]