Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,crypto: use std::variant in DH params #40457

Closed
wants to merge 1 commit into from
Closed

src,crypto: use std::variant in DH params #40457

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen [email protected]

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 14, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen force-pushed the src,crypto/use-std-variant-in-DH-params branch from 869f42a to 29a2559 Compare October 14, 2021 14:11
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Member

Added dont-land- labels as std::variant is a C++17 feature.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2021
@github-actions github-actions bot mentioned this pull request Oct 15, 2021
Open
23 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Oct 15, 2021
This was referenced Oct 16, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40334/

This was referenced Oct 18, 2021
Open
Open
Open
Open
Open
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2021
@github-actions
Copy link
Contributor

Landed in 68dc180...5c7af3f

@github-actions github-actions bot closed this Oct 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 22, 2021
@RaisinTen @nodejs-github-bot
src,crypto: use std::variant in DH params
5c7af3f 
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40457
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RaisinTen RaisinTen deleted the src,crypto/use-std-variant-in-DH-params branch October 22, 2021 14:45
@github-actions github-actions bot mentioned this pull request Oct 23, 2021
Open
31 tasks
targos pushed a commit that referenced this pull request Oct 23, 2021
@RaisinTen @targos
src,crypto: use std::variant in DH params
ef1ace7 
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40457
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaisinTen @nodejs-github-bot @richardlau @addaleax @tniessen