-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update fs.watchFile doc #40134
doc: update fs.watchFile doc #40134
Conversation
I mean, comparing new Date >= new Date; // true
new Date <= new Date; // true
new Date < new Date; // false
new Date > new Date; // false
new Date('1970-01-01') < new Date('2038-01-19'); // true
new Date('1970-01-01') > new Date('2038-01-19'); // false
// Equality on the other hand doesn't work
new Date == new Date // false
new Date('1970-01-01') == new Date('1970-01-01') // false |
Well, here the idea is to know whether a file has been modified by comparing modified times.
which doesn't work. Actually that's the root cause of a bug I just fixed. |
Keep in mind that "compare X and Y" does not mean "apply a JS comparison operator between X and Y"; for example, In any case, this can be sidestepped by just referring to |
The current wording suggests to compare Date objects, which won't work.
64ba157
to
b65821f
Compare
Landed in a2ed30b...2b02d2f |
The current wording suggests to compare Date objects, which won't work. PR-URL: #40134 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The current wording suggests to compare Date objects, which won't work. PR-URL: #40134 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
The current wording suggests to compare Date objects, which won't work.