-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "build: add windows-2022 to GitHub test matrix" #39982
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 13b569c. V8 9.3 is not compatible. Refs: nodejs#39976
Fast-track has been requested by @targos. Please 👍 to approve. |
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Sep 3, 2021
aduh95
approved these changes
Sep 3, 2021
lpinca
approved these changes
Sep 3, 2021
iam-frankqiu
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 3, 2021
iam-frankqiu
requested review from
iam-frankqiu
and removed request for
iam-frankqiu
September 3, 2021 11:10
tniessen
approved these changes
Sep 3, 2021
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 3, 2021
richardlau
approved these changes
Sep 3, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 3, 2021
Landed in 0c35fe0...95dffe7 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
This reverts commit 13b569c. V8 9.3 is not compatible. Refs: #39976 PR-URL: #39982 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added a commit
that referenced
this pull request
Sep 6, 2021
This reverts commit 13b569c. V8 9.3 is not compatible. Refs: #39976 PR-URL: #39982 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added a commit
that referenced
this pull request
Sep 6, 2021
This reverts commit 13b569c. V8 9.3 is not compatible. Refs: #39976 PR-URL: #39982 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 13b569c.
V8 9.3 is not compatible.
Refs: #39976