Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-domain-exit-dispose-again #3990

Closed
wants to merge 1 commit into from
Closed

test: fix test-domain-exit-dispose-again #3990

wants to merge 1 commit into from

Commits on Nov 23, 2015

  1. test: fix test-domain-exit-dispose-again 

    test-domain-exit-dispose-again had been written for node v0.10.x, and
was using the fact that callbacks scheduled with `process.nextTick`
wouldn't run if the domain attached to it was disposed.

This is not longer the case, and as a result the test would not catch
any regression: it would always pass.

This change rewrites that test to check that the current domain is
cleared properly when processing the rest of the timers list if a
timer's callback throws an error. This makes the test fail without the
original fix, and pass with the original fix, as expected.
    Julien Gilli committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    e7e7437 View commit details
    Browse the repository at this point in the history