Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update .mailmap to remove duplicate AUTHORS entry for addaleax #39880

Closed
wants to merge 1 commit into from
Closed

meta: update .mailmap to remove duplicate AUTHORS entry for addaleax #39880

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 25, 2021

No description provided.

@Trott Trott requested a review from addaleax August 25, 2021 13:03
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 25, 2021
richardlau
richardlau approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"update" is misspelled in the commit/PR title.

@Trott Trott changed the title meta: udpate .mailmap to remove duplicate AUTHORS entry for addaleax meta: update .mailmap to remove duplicate AUTHORS entry for addaleax Aug 25, 2021
@Trott
Copy link
Member Author

Trott commented Aug 25, 2021 •
edited
Loading

"update" is misspelled in the commit/PR title.

Fixed in both places. Thanks. I mistype that all the time. Guess I need to implement my "acceptable imperative verbs" rule in core-validate-commit.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 25, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2021
@github-actions
Copy link
Contributor

Landed in c04d621...95834d1

@github-actions github-actions bot closed this Aug 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 25, 2021
@Trott @nodejs-github-bot
meta: update .mailmap to remove duplicate AUTHORS entry for addaleax
95834d1 
PR-URL: #39880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Trott @targos
meta: update .mailmap to remove duplicate AUTHORS entry for addaleax
bc236a6 
PR-URL: #39880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 6, 2021
Merged
@Trott Trott deleted the duplicate branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @addaleax @lpinca @targos @richardlau @nodejs-github-bot