crypto: fix rsa-pss one-shot sign/verify error handling #39830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
panva
added
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Aug 21, 2021
panva
added
author ready
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/39830 ✔ Done loading data for nodejs/node/pull/39830 ----------------------------------- PR info ------------------------------------ Title crypto: fix rsa-pss one-shot sign/verify error handling (#39830) Author Filip Skokan (@panva) Branch panva:fix-oneshot-pss -> nodejs:master Labels crypto, c++, author ready, webcrypto Commits 1 - crypto: fix rsa-pss one-shot sign/verify error handling Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/39830 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39830 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 21 Aug 2021 11:28:00 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39830#pullrequestreview-735495160 ✖ This PR needs to wait 3 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-08-21T13:18:37Z: https://ci.nodejs.org/job/node-test-pull-request/39618/ - Querying data for job/node-test-pull-request/39618/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1176709244 |
github-actions
bot
added
the
commit-queue-failed
panva
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in e5670f4...b5816cd |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 28, 2021
fixes #39822 PR-URL: #39830 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
fixes #39822 PR-URL: #39830 Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
fixes #39822 PR-URL: #39830 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39822
cc @nodejs/crypto