Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add mailmap entries for ttzztztz and garygsc #39588

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 30, 2021

Add mailmap entries and re-run AUTHORS to remove duplicates.

@ttzztztz @GaryGSC If I haven't used the email addresses that you prefer for the AUTHORS file, please leave a comment. Thanks! (For garygsc, it's the gmail address, and for ttzztztz, it's the outlook address.)

Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 30, 2021
Copy link
Contributor

@ttzztztz ttzztztz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 30, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

Copy link
Contributor

@GaryGSC GaryGSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021
@github-actions
Copy link
Contributor

Landed in b4ae702...46e6c64

@github-actions github-actions bot closed this Jul 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 30, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 30, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott deleted the mailmap-again branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants