Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: rename TransferedReadableStream etc. #39352

Closed
wants to merge 1 commit into from
Closed

lib: rename TransferedReadableStream etc. #39352

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This does change some error messages, but, since it's an experimental module, that probably does not make it semver-major. I can move those changes to a separate PR if it is a concern.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 11, 2021
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member

targos commented Jul 12, 2021

I'd like to fast-track to include in the next v16.x release (the first to include web streams)

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38994/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 12, 2021 •
edited by tniessen
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38996/ (✔️)

@targos
Copy link
Member

targos commented Jul 13, 2021

Landed in 528639c

@targos targos closed this Jul 13, 2021
targos pushed a commit that referenced this pull request Jul 13, 2021
@tniessen @targos
lib: rename TransferedReadableStream etc
528639c 
PR-URL: #39352
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 13, 2021
@tniessen @targos
lib: rename TransferedReadableStream etc
ecf627a 
PR-URL: #39352
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jul 13, 2021
Merged
@richardlau
Copy link
Member

Blocked from 14.x as needs #39062 to land first.

@tniessen tniessen deleted the lib-rename-transfered-transferred-streams branch October 7, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @targos @nodejs-github-bot @richardlau @jasnell @lpinca @cjihrig @ronag