-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: update label-pr-config #38950
meta: update label-pr-config #38950
Conversation
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs.
IMO we should rename the label itself to be V8 engine since the correct name for the JavaScript engine is V8 and not v8. Non-blocking observation, though. This can happen some other time. |
Hmmm...although looking more closely, it appears that maybe we are taking a "lowercase everything all the time" approach in labels, perhaps to avoid ever having to think about it, in which case, yeah, this is good as is. |
@@ -35,7 +35,7 @@ subSystemLabels: | |||
/^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x | |||
|
|||
# don't label python files as c++ | |||
/^src\/.+\.py$/: lib / src, needs-ci | |||
/^src\/.+\.py$/: python, needs-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file pattern doesn't match anything in the current master
/ v12.x-staging
(I presume the same for the ones in between). On v10.x-staging
it matches
src/noperfctr_macros.py
src/notrace_macros.py
but Node.js 10 is End-of-Life.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I just remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind either way (I guess we could leave it in defensively in case a future PR reintroduces a Python file to src
).
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Landed in 07339ec |
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: nodejs#38950 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
a while ago).
request adding it landed).