repl: document top level await limitation with const/let

[jasnell]

Fixes: #17669
Signed-off-by: James M Snell [email protected]

[benjamingr]

@jasnell

BTW, why do your PRs all have:

Signed-off-by: James M Snell [email protected]

Is that a byproduct of using some particular software to author commits or does that signify anything?

[jasnell]

Is that a byproduct of using some particular software to author commits or does that signify anything?

It's added by using git commit --signoff

As for what it signifies... The answer is we technically should be requiring it for all commits from everyone as part of the DCO (Developer Certificate of Origin) requirements. This from the Dita project provides the most succinct explanation I've been able to find:

The DCO is a legally binding statement that asserts that you are the creator of your contribution, and that you license the work under the Apache License Version 2.0.

To indicate that you agree to the terms of the DCO, you “sign off” your contribution by adding a line with your name and e-mail address to every Git commit message:

Signed-off-by: Jane Doe [email protected]

You must use your real name (no pseudonyms or anonymous contributions are allowed.)

Your signature certifies that you are either the author of the contribution or have the right to submit it under the open-source license used by the DITA Open Toolkit project.

If you set your user.name and user.email as part of your Git configuration, you can sign your commit automatically with git commit -s.

For Node.js we do not enforce the "real name" requirement, but there's been a long-standing open discussion in the TSC pending feedback from the Linux Foundation legal representatives about whether we need to actually enforce the requirement of having the sign-off.

I add it myself in a subtle attempt at trying to make it catch on ;-)

[jasnell]

This shouldn't need to wait the full 48 hours to land. Please 👍🏻 to fast-track

[jasnell]

Landed in 346f0e9