Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify that fs.Dir async iterator closes automatically #38438

Closed
wants to merge 2 commits into from
Closed

doc: clarify that fs.Dir async iterator closes automatically #38438

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 27, 2021 •
edited
Loading

Signed-off-by: James M Snell [email protected]
Fixes: #35148

@github-actions github-actions bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 27, 2021
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Landed in 87aca07

@jasnell jasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
@jasnell
doc: clarify that fs.Dir async iterator closes automatically
87aca07 
Signed-off-by: James M Snell <[email protected]>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 29, 2021
@jasnell @targos
doc: clarify that fs.Dir async iterator closes automatically
1eae4af 
Signed-off-by: James M Snell <[email protected]>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@jasnell @targos
doc: clarify that fs.Dir async iterator closes automatically
7a92c3c 
Signed-off-by: James M Snell <[email protected]>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: undocumented magic: async iterator over fs.Dir will call dir.close() on iteration end
4 participants
@jasnell @addaleax @aduh95 @targos