-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mark querystring api as legacy #38436
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#38231
github-actions
bot
added
doc
Issues and PRs related to the documentations.
querystring
Issues and PRs related to the built-in querystring module.
labels
Apr 27, 2021
targos
approved these changes
Apr 27, 2021
aduh95
approved these changes
Apr 27, 2021
richardlau
approved these changes
Apr 27, 2021
jasnell
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Apr 27, 2021
Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻 |
addaleax
approved these changes
Apr 27, 2021
panva
pushed a commit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Landed in 32ade69 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38231 PR-URL: #38436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
querystring
Issues and PRs related to the built-in querystring module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell [email protected]
Fixes: #38231