Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move abort test from pummel to abort directory #38396

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 25, 2021

test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

@nodejs-github-bot

This comment has been minimized.

@targos targos added the test Issues and PRs related to the tests. label Apr 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: nodejs#38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 27, 2021

Landed in 6f296b5

@Trott Trott merged commit 6f296b5 into nodejs:master Apr 27, 2021
@Trott Trott deleted the release-the-pummel branch April 27, 2021 14:23
targos pushed a commit that referenced this pull request Apr 29, 2021
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: #38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: #38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: #38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: #38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.

PR-URL: #38396
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants