-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move abort test from pummel to abort directory #38396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Apr 25, 2021
addaleax
approved these changes
Apr 25, 2021
cjihrig
approved these changes
Apr 25, 2021
jasnell
approved these changes
Apr 25, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: nodejs#38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
force-pushed
the
release-the-pummel
branch
from
April 27, 2021 14:22
2e826f7
to
6f296b5
Compare
Landed in 6f296b5 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.