src: fix setting Converter sub char length #38331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#38330
nodejs-github-bot
added
c++
juanarbol
approved these changes
Apr 21, 2021
benjamingr
approved these changes
Apr 21, 2021
benjamingr
approved these changes
Apr 21, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
pushed a commit
that referenced
this pull request
Apr 24, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in 639fa32 |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Signed-off-by: James M Snell <[email protected]> Fixes: #38330 PR-URL: #38331 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell [email protected]
Fixes: #38330