Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update BUILDING.md for Apple Silicon #38227

Closed
wants to merge 1 commit into from
Closed

doc: Update BUILDING.md for Apple Silicon #38227

wants to merge 1 commit into from

Conversation

AshCripps
Copy link
Member

Update BUILDING.md to be correct for Apple Silicon for 16.x

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 13, 2021
@aduh95 aduh95 added arm Issues and PRs related to the ARM platform. macos Issues and PRs related to the macOS platform / OSX. labels Apr 13, 2021
@aduh95
Copy link
Contributor

aduh95 commented Apr 13, 2021

Does this need to be backported to v14.x and v15.x?

@AshCripps
Copy link
Member Author

AshCripps commented Apr 13, 2021 •
edited
Loading

Does this need to be backported to v14.x and v15.x?

No we dont release for Apple silicon on those lines

@BethGriggs BethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2021
@BethGriggs
Copy link
Member

Fast-track?

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2021
Merged
AshCripps pushed a commit that referenced this pull request Apr 14, 2021
doc: update BUILDING.md for Apple Silicon
98c2067 
PR-URL: #38227
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@AshCripps
Copy link
Member Author

Landed in 98c2067

@AshCripps AshCripps closed this Apr 14, 2021
@AshCripps AshCripps deleted the update-building-md branch April 15, 2021 10:21
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@BethGriggs
doc: update BUILDING.md for Apple Silicon
d2ec75a 
PR-URL: #38227
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AshCripps @aduh95 @BethGriggs @Trott @targos @gengjiawen @richardlau @nodejs-github-bot