-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zlib: refactor to avoid unsafe array iteration #36722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchougule
reviewed
Jan 1, 2021
Benchmark didn't show any significant regression.
|
aduh95
added
dont-land-on-v10.x
review wanted
PRs that need reviews.
and removed
needs-benchmark-ci
PR that need a benchmark CI run.
labels
Jan 2, 2021
Trott
approved these changes
Jan 12, 2021
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 12, 2021
jasnell
approved these changes
Jan 12, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 13, 2021
PoojaDurgad
approved these changes
Jan 13, 2021
PR-URL: nodejs#36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
aduh95
force-pushed
the
zlib-array-iteration
branch
from
January 13, 2021 14:52
b7f6ee1
to
251a0ff
Compare
Landed in 251a0ff |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
zlib
Issues and PRs related to the zlib subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes