-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: replace public Map methods with primordials #36652
Conversation
Does this need to be benchmarked against |
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/895/ EDIT: Didn't show any perf regression or improvement 👍 Benchmark results
|
Alternatively, it might be better to fix the C++ binding, so that |
Agreed, having to deal only with
I've been looking into that, and it seems all the C++ API does is create a Lines 275 to 277 in 7efada6
This could be done in JS, no need to change the C++, but I wouldn't be surprised if it had worse performance (haven't measured it though). |
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #36989 Refs: #36652 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes