doc: expand openssl instructions #36554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#36541 Expand the instructions to cover what is needed when updates are required across all active release lines
2 tasks
richardlau
reviewed
Dec 17, 2020
doc/guides/maintaining-openssl.md
Outdated
| @@ -2,6 +2,18 @@ | |||
|
|
|||
| This document describes how to update `deps/openssl/`. | |||
|
|
|||
| If you need to provide updates across all active release lines you will | |||
| currently need to generate two PRs as follows: | |||
There was a problem hiding this comment.
This time round we did three PRs -- one for current (including the QUIC patches), one for 14.x (without the the QUIC patches) and one for 10.x.
There was a problem hiding this comment.
k will update for that.
richardlau
approved these changes
Dec 18, 2020
|
@MylesBorins could you review/approve so I can land? |
MylesBorins
approved these changes
Dec 21, 2020
|
@MylesBorins understood on updating the docs. I can try to remember to do that, but I think the value of having the info is worth it. |
|
Do only change and linters have passed, landing. |
mhdawson
added a commit
that referenced
this pull request
Dec 22, 2020
Refs: #36541 Expand the instructions to cover what is needed when updates are required across all active release lines PR-URL: #36554 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Landed in e22b751 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Refs: #36541 Expand the instructions to cover what is needed when updates are required across all active release lines PR-URL: #36554 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 16, 2021
Refs: #36541 Expand the instructions to cover what is needed when updates are required across all active release lines PR-URL: #36554 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Refs: #36541 Expand the instructions to cover what is needed when updates are required across all active release lines PR-URL: #36554 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #36541
Expand the instructions to cover what is needed when
updates are required across all active release lines
Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes