readline: refactor to use more primordials #36296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
readline
Trott
approved these changes
Nov 29, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in e074bee...ed6e71a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 4, 2020
PR-URL: #36296 Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36296 Reviewed-By: Rich Trott <[email protected]>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36296 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36296 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36296 Reviewed-By: Rich Trott <[email protected]>
|
Hey, this is breaking in the v16.x release branch by the |
|
Nevermind, this is a quite all commit; this is part of v16.x branch already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes