Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: refactor to use more primordials #36285

Closed
wants to merge 1 commit into from
Closed

v8: refactor to use more primordials #36285

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
Copy link
Member

Trott commented Nov 28, 2020

Benchmark CI (queued): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/719/

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 28, 2020

Benchmark results:

                                                          confidence improvement accuracy (*)   (**)  (***)
v8/get-stats.js n=1000000 method='getHeapSpaceStatistics'                 0.37 %       ±2.35% ±3.13% ±4.10%
v8/get-stats.js n=1000000 method='getHeapStatistics'                     -0.27 %       ±4.07% ±5.41% ±7.05%

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34605/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

Landed in e6e7084...dbfb10d

@github-actions github-actions bot closed this Dec 1, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 1, 2020
@aduh95 @nodejs-github-bot
v8: refactor to use more primordials
dbfb10d 
PR-URL: #36285
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 deleted the v8-primordials branch December 1, 2020 14:29
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
v8: refactor to use more primordials
fbd5652 
PR-URL: #36285
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@aduh95 @cjihrig
v8: refactor to use more primordials
1c12838 
PR-URL: nodejs#36285
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
v8: refactor to use more primordials
d49ec9b 
PR-URL: #36285
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
v8: refactor to use more primordials
6c1bbb5 
PR-URL: #36285
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Trott @nodejs-github-bot @lpinca