test: remove flaky designation from ls-no-sslv3 #3620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: nodejs#2554
|
LGTM |
1 similar comment
|
LGTM |
|
(This was one of the tests that only failed within the weird accept-pr setup) |
|
Landed in f6230b9 |
Trott
added a commit
that referenced
this pull request
Nov 2, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Trott
added a commit
that referenced
this pull request
Nov 7, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Merged
|
@jasnell I am imagining that commits like these would be best added just before cutting a release in order to minimize headache if there is a regression with CI. Thoughts? |
|
likely a good idea |
Trott
added a commit
that referenced
this pull request
Dec 1, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 4, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Closed
Trott
added a commit
that referenced
this pull request
Dec 17, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Trott
added a commit
that referenced
this pull request
Dec 23, 2015
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: #2554 PR-URL: #3620 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was marked flaky after failing in CI on arm7-wheezy two months
ago. It has not failed there since. This commit removes the flaky
designation.
Fixes: #2554