child_process: don't fork bomb ourselves from -e #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
the
child_process
|
LGTM |
|
LGTM |
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: nodejs#3574
PR-URL: nodejs#3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
|
suggesting this goes into |
|
Agreed but likely better to land it post v4.2.2 |
|
It's not a regression in any way (it's a buglet that apparently goes all the way back to v0.6) so it would IMO be perfectly acceptable to leave it out of LTS. |
|
@bnoordhuis .. noted! 👍 On Fri, Oct 30, 2015 at 9:55 AM, Ben Noordhuis [email protected]
|
bnoordhuis
added a commit
that referenced
this pull request
Nov 7, 2015
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: #3574
PR-URL: #3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
|
@jasnell @bnoordhuis @rvagg has this spent enough time in 5.1.0? |
|
@thealphanerd ... I'd say yes. |
bnoordhuis
added a commit
that referenced
this pull request
Nov 30, 2015
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: #3574
PR-URL: #3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
|
Yes, I think so. EDIT: I see you landed it a few minutes ago. :-) |
bnoordhuis
added a commit
that referenced
this pull request
Dec 4, 2015
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: #3574
PR-URL: #3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Closed
bnoordhuis
added a commit
that referenced
this pull request
Dec 17, 2015
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: #3574
PR-URL: #3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
bnoordhuis
added a commit
that referenced
this pull request
Dec 23, 2015
Remove the `-e` argument from process.execArgv in child_process.fork()
to keep `node -e 'require("child_process").fork("empty.js")'` from
spawning itself recursively.
Fixes: #3574
PR-URL: #3575
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
-eargument from process.execArgv in child_process.fork()to keep
node -e 'require("child_process").fork("empty.js")'fromspawning itself recursively.
Fixes: #3574
R=@Trott
CI: https://ci.nodejs.org/job/node-test-pull-request/643/