Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add startup team in CODEOWNERS #35406

Closed
wants to merge 1 commit into from
Closed

meta: add startup team in CODEOWNERS #35406

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Sep 29, 2020 •
edited
Loading

Fixes: #35215

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@joyeecheung joyeecheung added the meta Issues and PRs related to the general management of the project. label Sep 29, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@joyeecheung joyeecheung mentioned this pull request Sep 29, 2020
Closed
@gengjiawen
Copy link
Member

gengjiawen commented Sep 29, 2020 •
edited
Loading

Looks like we will abandon build-in CODEOWNERS, see #35162 (comment). cc @mmarchini

@joyeecheung
Copy link
Member Author

joyeecheung commented Sep 29, 2020 •
edited
Loading

@gengjiawen I thought the decision was to not rely on GitHub to do the ping but instead rely on the bot (which will parse the CODEOWNERS and ping people, like what it's doing in #35406 (comment))?

@gengjiawen
Copy link
Member

@gengjiawen I thought the decision was to not rely on GitHub to do the ping but instead rely on the bot (which will parse the CODEOWNERS and ping people, like what it's doing in #35406 (comment))?

Another thing is that you may want to is add this repo to startup team see: #35162 (comment).

gengjiawen
gengjiawen approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we set the team truly to startup :)

@joyeecheung
Copy link
Member Author

I am not sure whether we should add the team under nodejs/collaborators now (last time I checked there were permission issues?). Maybe @mmarchini has a clue?

mhdawson
mhdawson approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XadillaX
XadillaX approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung mentioned this pull request Oct 1, 2020
Closed
joyeecheung added a commit that referenced this pull request Oct 3, 2020
@joyeecheung
meta: add startup team in CODEOWNERS
f826760 
PR-URL: #35406
Fixes: #35215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung
Copy link
Member Author

Landed in f826760

@joyeecheung joyeecheung closed this Oct 3, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@joyeecheung @danielleadams
meta: add startup team in CODEOWNERS
2302206 
PR-URL: #35406
Fixes: #35215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@joyeecheung @joesepi
meta: add startup team in CODEOWNERS
3f66c09 
PR-URL: nodejs#35406
Fixes: nodejs#35215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@XadillaX XadillaX XadillaX approved these changes

@codebytere codebytere codebytere approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a nodejs/startup team