Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland workaround for perf-basic-prof filename truncation issue #3520

Closed
wants to merge 1 commit into from
Closed

Reland workaround for perf-basic-prof filename truncation issue #3520

wants to merge 1 commit into from

Commits on Oct 26, 2015

  1. deps: backport 010897c from V8 upstream 

    This is a reland of nodejs#3165. The patch abates
the truncation of script filenames in the perf-event output produced by V8.

V8 commits:
Original: v8/v8@03ef3cd
Reland: v8/v8@010897c

Original commit message:
  improve perf_basic_prof filename reporting

  The buffer used for appending filenames to the string printed to the
  perf_basic_prof log was unnecessarily too small. Bump it up to be at least
  kUtf8BufferSize.

  Truncation of filenames makes it really hard to work with profiles gathered on
  Node.js. Because of the way Node.js works, you can have node module dependencies
  in deeply nested directories. The last thing you want when investigating a
  performance problem is to have script names be truncated.

  This patch is a stop-gap. Ideally, I want no truncation of the filename at all
  and use a dynamically growing buffer. That would be a larger change, and I
  wanted to have a quick fix available that can be back-ported to Node.js LTS
  release.

  [email protected],[email protected]
  BUG=

  Review URL: https://codereview.chromium.org/1388543002
    @ofrobots
    ofrobots committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    d1839c3 View commit details
    Browse the repository at this point in the history