Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use process.env.PYTHON to spawn python #34700

Closed
wants to merge 1 commit into from
Closed

test: use process.env.PYTHON to spawn python #34700

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 9, 2020

Fixes: #34699

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 9, 2020
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32697/

This was referenced Aug 10, 2020
Open
Open
gengjiawen
gengjiawen approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thought export this in common ?

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32702/ ✅

@addaleax
Copy link
Member Author

Any thought export this in common ?

I don’t have a strong opinion on that.

This was referenced Aug 11, 2020
Open
Open
Open
Open
Open
Open
This was referenced Aug 14, 2020
Open
Open
rickyes pushed a commit that referenced this pull request Aug 14, 2020
@addaleax @rickyes
test: use process.env.PYTHON to spawn python
888eb5a 
Co-authored-by: Jérémy Lal <[email protected]>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@rickyes
Copy link
Contributor

rickyes commented Aug 14, 2020

Landed in 888eb5a

@rickyes rickyes closed this Aug 14, 2020
@github-actions github-actions bot mentioned this pull request Aug 15, 2020
Open
6 tasks
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@addaleax @MylesBorins
test: use process.env.PYTHON to spawn python
e0e8544 
Co-authored-by: Jérémy Lal <[email protected]>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@addaleax @BethGriggs
test: use process.env.PYTHON to spawn python
a78c638 
Co-authored-by: Jérémy Lal <[email protected]>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: use process.env.PYTHON to spawn python
9565d59 
Co-authored-by: Jérémy Lal <[email protected]>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: use process.env.PYTHON to spawn python
9cde4eb 
Co-authored-by: Jérémy Lal <[email protected]>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nelias Nelias Nelias approved these changes

@rickyes rickyes rickyes approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests call python instead of env.PYTHON
8 participants
@addaleax @nodejs-github-bot @rickyes @jasnell @lpinca @gengjiawen @richardlau @Nelias