test: use block-scoping in test/pummel/test-timers.js #34630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Aug 5, 2020
|
Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15751/ (:green_heart:) |
Trott
added
the
author ready
targos
approved these changes
Aug 11, 2020
|
Landed in 49a1f7f |
Trott
force-pushed
the
block-scope-test-timers
branch
from
bde6b0d to
49a1f7f
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #34630 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34630 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34630 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34630 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes