doc: update fs.watch() availability for IBM i #34611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
ghost
commented
Aug 3, 2020
| @@ -4016,6 +4016,7 @@ to be notified of filesystem changes. | |||
| * On SunOS systems (including Solaris and SmartOS), this uses [`event ports`][]. | |||
| * On Windows systems, this feature depends on [`ReadDirectoryChangesW`][]. | |||
| * On Aix systems, this feature depends on [`AHAFS`][], which must be enabled. | |||
| * On IBM i systems, this feature is not supported. | |||
There was a problem hiding this comment.
I didn't add any line suggesting to use fs.watchFile() as this option is mentioned later.
|
@richardlau take a look when you have a spare minute |
richardlau
reviewed
Aug 3, 2020
|
cc @nodejs/platform-ibmi |
|
@richardlau Sure Probably some formatting is done by my IDE. I'll fix this |
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability
ghost
commented
Aug 3, 2020
richardlau
approved these changes
Aug 3, 2020
richardlau
added
ibm i
|
LGTM. Thanks, @iandrc!! |
|
@ThePrez np :) |
jasnell
approved these changes
Aug 7, 2020
jasnell
pushed a commit
that referenced
this pull request
Aug 7, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0dff5bc |
addaleax
pushed a commit
that referenced
this pull request
Aug 8, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a line that IBM i does not support `fs.watch()`. Fixes: #34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: #34611 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a line that IBM i does not support
fs.watch().Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability
Checklist