Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add debugging for test-https-foafssl.js #34603

Closed
wants to merge 2 commits into from
Closed

test: add debugging for test-https-foafssl.js #34603

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 2, 2020

The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: add debugging for test-https-foafssl.js
1a28fbe 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: nodejs#24397
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4192

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 2, 2020
@Trott
Copy link
Member Author

Trott commented Aug 2, 2020

Helpful! Stress test gives these results on a failure:

12:11:05 not ok 3 parallel/test-https-foafssl
12:11:05   ---
12:11:05   duration_ms: 120.232
12:11:05   severity: fail
12:11:05   exitcode: 1
12:11:05   stack: |-
12:11:05     timeout
12:11:05     got request
12:11:05     sent response
12:11:05   ...

@Trott
test: add debugging for callbacks in test-https-foafssl.js
0140734 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: nodejs#24397
@Trott
Copy link
Member Author

Trott commented Aug 2, 2020

Added more debugging and will run another stress test...

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2020
@Trott
Copy link
Member Author

Trott commented Aug 4, 2020

With current debugging info:

not ok 4 parallel/test-https-foafssl
  ---
  duration_ms: 120.380
  severity: fail
  exitcode: 1
  stack: |-
    timeout
    got request
    sent response
    stream finished

jasnell pushed a commit that referenced this pull request Aug 7, 2020
@Trott @jasnell
test: add debugging for test-https-foafssl.js
57c8549 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Aug 7, 2020
@Trott @jasnell
test: add debugging for callbacks in test-https-foafssl.js
93959b2 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 7, 2020

Making the assumption that the Lite-CI for this one is sufficient... Landed in 0dff5bc...93959b2

@jasnell jasnell closed this Aug 7, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@Trott @addaleax
test: add debugging for test-https-foafssl.js
2133b18 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 8, 2020
@Trott @addaleax
test: add debugging for callbacks in test-https-foafssl.js
ca89c37 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@Trott @codebytere
test: add debugging for test-https-foafssl.js
4cd9c4f 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Aug 11, 2020
@Trott @codebytere
test: add debugging for callbacks in test-https-foafssl.js
27333b1 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: add debugging for test-https-foafssl.js
e05f80b 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: add debugging for callbacks in test-https-foafssl.js
0e823e3 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: add debugging for test-https-foafssl.js
4dbc787 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: add debugging for callbacks in test-https-foafssl.js
7eb8040 
The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.

Refs: #24397

PR-URL: #34603
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@Trott Trott deleted the foaf branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyes rickyes rickyes approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @jasnell @joyeecheung @rickyes