From 8b4adb267b9320c78e1508b1c973efd256e15b21 Mon Sep 17 00:00:00 2001 From: Wyatt Preul Date: Mon, 24 Aug 2015 16:40:38 -0500 Subject: [PATCH] util: Remove p, has been deprecated for years Update deprecation test to use another method. Ref: https://github.com/nodejs/node/pull/2529 PR-URL: https://github.com/nodejs/node/pull/3432 Reviewed-By: Brian White Reviewed-By: Jeremiah Senkpiel --- lib/util.js | 7 ------- test/fixtures/deprecated.js | 2 +- test/sequential/test-deprecation-flags.js | 10 +++++----- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/lib/util.js b/lib/util.js index 399a4ee0a23828..19d3d464f104d4 100644 --- a/lib/util.js +++ b/lib/util.js @@ -790,13 +790,6 @@ function hasOwnProperty(obj, prop) { // Deprecated old stuff. -exports.p = internalUtil.deprecate(function() { - for (var i = 0, len = arguments.length; i < len; ++i) { - console.error(exports.inspect(arguments[i])); - } -}, 'util.p is deprecated. Use console.error instead.'); - - exports.exec = internalUtil.deprecate(function() { return require('child_process').exec.apply(this, arguments); }, 'util.exec is deprecated. Use child_process.exec instead.'); diff --git a/test/fixtures/deprecated.js b/test/fixtures/deprecated.js index be4bc4ae0d3558..f49c0d91ba1249 100644 --- a/test/fixtures/deprecated.js +++ b/test/fixtures/deprecated.js @@ -1 +1 @@ -require('util').p('This is deprecated'); +require('util').debug('This is deprecated'); diff --git a/test/sequential/test-deprecation-flags.js b/test/sequential/test-deprecation-flags.js index ca325654c55d80..a243cc44f29dd7 100644 --- a/test/sequential/test-deprecation-flags.js +++ b/test/sequential/test-deprecation-flags.js @@ -16,8 +16,8 @@ execFile(node, normal, function(er, stdout, stderr) { console.error('normal: show deprecation warning'); assert.equal(er, null); assert.equal(stdout, ''); - assert.equal(stderr, '(node) util.p is deprecated. Use console.error ' + - 'instead.\n\'This is deprecated\'\n'); + assert.equal(stderr, '(node) util.debug is deprecated. Use console.error ' + + 'instead.\nDEBUG: This is deprecated\n'); console.log('normal ok'); }); @@ -25,7 +25,7 @@ execFile(node, noDep, function(er, stdout, stderr) { console.error('--no-deprecation: silence deprecations'); assert.equal(er, null); assert.equal(stdout, ''); - assert.equal(stderr, '\'This is deprecated\'\n'); + assert.equal(stderr, 'DEBUG: This is deprecated\n'); console.log('silent ok'); }); @@ -36,8 +36,8 @@ execFile(node, traceDep, function(er, stdout, stderr) { var stack = stderr.trim().split('\n'); // just check the top and bottom. assert.equal(stack[0], - 'Trace: util.p is deprecated. Use console.error instead.'); - assert.equal(stack.pop(), '\'This is deprecated\''); + 'Trace: util.debug is deprecated. Use console.error instead.'); + assert.equal(stack.pop(), 'DEBUG: This is deprecated'); console.log('trace ok'); });