Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add util/types alias module #34055

Closed
wants to merge 2 commits into from
Closed

util: add util/types alias module #34055

wants to merge 2 commits into from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 25, 2020 •
edited
Loading

This should be the last alias module, unless we also want to add alias modules for the constants exports.

Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34962

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 25, 2020
@ExE-Boss ExE-Boss force-pushed the lib/util/add-util-types-alias-module branch from ec57841 to 8272c46 Compare June 25, 2020 17:18
@jasnell
Copy link
Member

jasnell commented Jun 25, 2020

unless we also want to add alias modules for the constants exports.

Definite -1 on that ;-)

@richardlau richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 25, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
targos
targos requested changes Jun 27, 2020
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be documented in a more visible way than the "changes:" section.

@ExE-Boss ExE-Boss force-pushed the lib/util/add-util-types-alias-module branch from 8272c46 to 86bc1db Compare June 27, 2020 13:40
@ExE-Boss ExE-Boss requested a review from targos June 27, 2020 13:47
@ExE-Boss
Copy link
Contributor Author

Can we get this into v15.0?

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ExE-Boss ExE-Boss mentioned this pull request Aug 28, 2020
Closed
4 tasks
@ExE-Boss
Copy link
Contributor Author

There’s also the path.posix and path.win32 namespaces that would also benefit from alias modules: #34962.

@ExE-Boss ExE-Boss mentioned this pull request Sep 29, 2020
Merged
@guybedford guybedford mentioned this pull request Oct 3, 2020
Closed
@ExE-Boss ExE-Boss mentioned this pull request Oct 6, 2020
Closed
ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Oct 6, 2020
@ExE-Boss
path: add path/posix and path/win32 alias modules
4c75a27 
Refs: nodejs#31553
Refs: nodejs#32953
Refs: nodejs#33950
Refs: nodejs#34001
Refs: nodejs#34002
Refs: nodejs#34055
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Oct 8, 2020

@jasnell @targos
Can we please get this merged?

MylesBorins
MylesBorins approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ExE-Boss
Copy link
Contributor Author

review?(@mcollina, @tniessen, @Trott)

@Trott
Copy link
Member

Trott commented Oct 13, 2020

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2515/ (queued, will 404 until it starts)

@ExE-Boss
Copy link
Contributor Author

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

@Trott
Copy link
Member

Trott commented Oct 18, 2020

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

We're a few weeks past the semver-major cut-off date for 15.x.x so this would probably require assent from both @nodejs/tsc and Releasers (and in particular @BethGriggs who is preparing the release) to land in 15.x.x.

@richardlau Is this semver major because it might have a naming clash with existing modules? Or is there another reason?

@aduh95
Copy link
Contributor

aduh95 commented Oct 20, 2020

Landed in c2ceb15

@aduh95 aduh95 closed this Oct 20, 2020
aduh95 pushed a commit that referenced this pull request Oct 20, 2020
@ExE-Boss @aduh95
util: add util/types alias module
c2ceb15 
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002

PR-URL: #34055
Refs: #34962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@rickyes rickyes removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 21, 2020
@ExE-Boss ExE-Boss deleted the lib/util/add-util-types-alias-module branch October 21, 2020 10:57
@ExE-Boss ExE-Boss mentioned this pull request Oct 21, 2020
Closed
2 tasks
@ExE-Boss ExE-Boss mentioned this pull request Oct 24, 2020
Closed
ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Oct 24, 2020
@ExE-Boss @aduh95
@trivikr @Trott
doc: document changes for */promises alias modules
ae296f9 
Fixes: nodejs#35740

Refs: nodejs#31553
Refs: nodejs#32953
Refs: nodejs#33991
Refs: nodejs#34001
Refs: nodejs#34055
Refs: nodejs#34962

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2020
@ExE-Boss @nodejs-github-bot
doc: document changes for */promises alias modules
1d5b91d 
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Rich Trott <[email protected]>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Nov 3, 2020
@ExE-Boss @targos
doc: document changes for */promises alias modules
55b7a6c 
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Rich Trott <[email protected]>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Nov 11, 2020
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@ExE-Boss @codebytere
path: add path/posix and path/win32 alias modules
85c85d3 
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34055

PR-URL: #34962
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@ExE-Boss @codebytere
util: add util/types alias module
baa87c1 
Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002

PR-URL: #34055
Refs: #34962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
codebytere added a commit that referenced this pull request Nov 22, 2020
@codebytere
2020-11-24, Version 15.3.0 (Current)
ac213a0 
Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: TODO
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
codebytere added a commit that referenced this pull request Nov 24, 2020
@codebytere
2020-11-24, Version 15.3.0 (Current)
636a649 
Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: TODO
codebytere added a commit that referenced this pull request Nov 24, 2020
@codebytere
2020-11-24, Version 15.3.0 (Current)
63e7dc1 
Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: #36232
codebytere added a commit that referenced this pull request Nov 24, 2020
@codebytere
2020-11-24, Version 15.3.0 (Current)
7b5b8ef 
Notable changes:

dns:
  * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099
events:
  * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001
http:
  * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048
http2:
  * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978
lib:
  * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716
path:
  * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962
readline:
  * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675
src:
  * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940
util:
  * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055

PR-URL: #36232
targos pushed a commit that referenced this pull request May 16, 2021
@ExE-Boss @targos
doc: document changes for */promises alias modules
ef7d3b1 
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Rich Trott <[email protected]>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
@ExE-Boss @targos
doc: document changes for */promises alias modules
1d80f89 
Fixes: #35740

Refs: #31553
Refs: #32953
Refs: #33991
Refs: #34001
Refs: #34055
Refs: #34962

Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Rich Trott <[email protected]>

PR-URL: #34002
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.