-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove ref to tools/generate_code_cache.js #33825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md.
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Jun 10, 2020
richardlau
approved these changes
Jun 10, 2020
devnexen
approved these changes
Jun 11, 2020
danbev
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jun 15, 2020
danbev
added a commit
that referenced
this pull request
Jun 15, 2020
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: #33825 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]>
Landed in 5959ae3. |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: #33825 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: #33825 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: #33825 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This commit removes the reference to tools/generate_code_cache.js and replaces it with a note about more information being available in tools/code_cache/README.md. PR-URL: #33825 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the reference to
tools/generate_code_cache.js
and replaces it with a note about more information being available
in tools/code_cache/README.md
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes