Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix FastStringKey equal operator #33748

Closed
wants to merge 1 commit into from
Closed

src: fix FastStringKey equal operator #33748

wants to merge 1 commit into from

Conversation

sapics
Copy link
Contributor

@sapics sapics commented Jun 5, 2020

  1. This PR fixes the FastStringKey == operator. (Currently, there are some cases which return true, when the length of string is not same).
  2. Currently, FastStringKey::HashImpl return multiple of 33, thus it would be better to move while to first.
Checklist

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 5, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31850/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31934/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31956/

This was referenced Jun 20, 2020
Open
Open
Open
Open
jasnell pushed a commit that referenced this pull request Jun 24, 2020
@sapics @jasnell
src: fix FastStringKey equal operator
5a0c6a6 
PR-URL: #33748
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 24, 2020

Landed in 5a0c66

@jasnell jasnell closed this Jun 24, 2020
@sapics sapics deleted the fix-faststringkey-operator branch June 24, 2020 23:35
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@sapics @codebytere
src: fix FastStringKey equal operator
e1bebf1 
PR-URL: #33748
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@sapics @codebytere
src: fix FastStringKey equal operator
0190cf6 
PR-URL: #33748
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@codebytere
Copy link
Member

Backport blocked on #33139

@sapics
Copy link
Contributor Author

sapics commented Jul 11, 2020

Thank you for trying backport!
This PR fixes the bug of the functionality which created in #33139.
Thus, if #33139 is not backported, it is okay if we cannot backport this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sapics @nodejs-github-bot @jasnell @codebytere @addaleax @benjamingr @cjihrig @MrHeer