tools: fix master branch build for Windows on Arm #33511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
arm
richardlau
reviewed
May 22, 2020
jasnell
approved these changes
May 27, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. Change-Id: I011134f5680719e8fc246b8c660ececf0c596fd8
richard-townsend-arm
force-pushed
the
woa-compile-fix
branch
from
653a867
to
7725262
Compare
|
Cool, so the possibly Win 7 breaking change is now gated behind a flag. CI flakes look spurious (they all fail on platforms that are unchanged). Ready for review. Once the change is adopted, I'll build and test the master branch daily and try to fix any failures as they arise. |
richardlau
approved these changes
May 29, 2020
codebytere
approved these changes
May 29, 2020
|
Cool, thanks for that - I don’t have permission to merge though. |
BridgeAR
added
the
author ready
|
Landed in 99abaf9...ce025d9 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: #33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
@richard-townsend-arm this conflicts in a handful of places - could you please manually backport it to v12.x? |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 14, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 14, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 14, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 14, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 15, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2021
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #32867, the new version of V8 (and new version of zlib) require a few definition fixups. After this, the master branch should build successfully for Windows on Arm.
CC @joaocgreis
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes